Implements #87 using HTTP::BrowserDetect - #121
Merged
Merged
Conversation
drn05r
commented
Apr 27, 2026
drn05r
commented
Contributor
- Uses HTTP::BrowserDetect to get basic name of browser (e.g. Firefox, Google Chrome, Safari, etc.).
- Keeps fallback to old method if HTTP::BrowserDetect not installed.
- If using old method ensure consistent order and allows customisation in z_irstats2.pl
- Uses HTTP::BrowserDetect to get basic name of browser (e.g. Firefox, Google Chrome, Safari, etc.). - Keeps fallback to old method if HTTP::BrowserDetect not installed. - If using old method ensure consistent order and allows customisation in z_irstats2.pl
drn05r
changed the title
MrBunsy
approved these changes
May 6, 2026
MrBunsy
left a comment
MrBunsy
left a comment
Contributor
There was a problem hiding this comment.
Might be worth a comment in the default config file that the commented out browser signatures would only be used to override defaults if HTTP::BrowserDetect isn't installed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.