Public-launch polish (review follow-ups) - #3
Merged
Merged
Conversation
From the public-launch readiness review:
- Remove .agents/ — a leaked internal AI-assistant rules file (local `fish`
shell instructions) that doesn't belong in a public repo; gitignore
editor/AI-tool directories.
- Remove the client/ scratch test client: committed compiled client.js, two
competing lockfiles, default tsconfig, an ISC license, and a dependency on
the OLD native `@eosrio/node-abieos` that contradicts the pure-Rust story.
- Align the sample config to one canonical form across `config init`
(src/config_sample.rs), example.config.json, and the README ("SHiP Node 1/2"
on 127.0.0.1:18080 / :28080).
- CHANGELOG: the release workflow ships cross-platform binaries, not a single
"Linux binary".
- CONTRIBUTING: clarify build+test run on Linux/macOS/Windows while fmt+clippy
run on Linux.
(Private Vulnerability Reporting and Discussions were enabled in repo settings,
so the SECURITY.md / CoC / issue-template links now resolve as written.)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the fleet-router-test-client TypeScript project and its associated configuration files, and updates .gitignore to exclude local AI assistant directories. It also refines documentation in CHANGELOG.md and CONTRIBUTING.md regarding cross-platform support and CI processes, and updates node names and endpoints in example.config.json and src/config_sample.rs for consistency. As there are no review comments, I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the public-launch readiness review, before the crates.io publish.
Repo hygiene
.agents/— a leaked internal AI-assistant rules file (localfishshell instructions). Doesn't belong in a public repo. Added.agents/,.claude/,.cursor/,.windsurf/to.gitignore.client/— an uncleaned scratch test client: a committed compiledclient.js, two competing lockfiles (bun.lock+package-lock.json), a verbose defaulttsconfig.json, anISClicense, and a dependency on the old native@eosrio/node-abieos— which contradicts the "pure Rust, no native deps" story.Consistency
config initoutput (src/config_sample.rs),example.config.json, and the README:SHiP Node 1/SHiP Node 2on127.0.0.1:18080/:28080. (Previously three different name/port variants.)ci.yml).Repo settings (done out-of-band)
Enabled Private Vulnerability Reporting and Discussions on the repo, so the SECURITY.md / CoC / issue-template links resolve as written — no doc changes needed for those.
Verified locally:
cargo fmt --checkandcargo build --workspacepass; full CI (3-OS matrix) runs on this PR.