Skip to content

fix(p2p): handshake signature - #210

Open
benjiewheeler wants to merge 1 commit into
eoscanada:developfrom
benjiewheeler:develop
Open

fix(p2p): handshake signature#210
benjiewheeler wants to merge 1 commit into
eoscanada:developfrom
benjiewheeler:develop

Conversation

@benjiewheeler

@benjiewheeler benjiewheeler commented Jul 26, 2023

Copy link
Copy Markdown

Background

The handshake resulted in invalid signature and the program crashes with the error

p2p message, invalid signature: the inner signature structure must be present, was nil

Summary

This PR changes:

  • the public key used in the HandshakeMessage from hardcoded to randomly generated
  • the signature is now generated from the private key
  • the handshake token to the the sha256 checksum of the handshake's timestamp

Note

Checklist

  • Backward compatible?
  • Test enough in your local environment?
  • Add related test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant