[WIP] fix: get_producer type add & test - #198
Open
psy2848048 wants to merge 1 commit into
Open
Conversation
Contributor
|
@psy2848048 I'm not sure I understand your comment. I saw the diff, only thing I see that changes outside of tests is the change from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Summary
When parsing
total_producer_vote_weight, the float64 value shows as4.403240198383598e+20So, there is a data loss in parsing.
But I think this loss is not really important in the lower digit part loss. What do you think?
If yes, I'll change the expected data to pass the test.
Note
Checklist