Demangle function name on decomp.me scratch creation#329
Open
0x5abe wants to merge 1 commit intoencounter:mainfrom
Open
Demangle function name on decomp.me scratch creation#3290x5abe wants to merge 1 commit intoencounter:mainfrom
0x5abe wants to merge 1 commit intoencounter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests this simply sets the name of a newly created decomp.me scratch to the demangled function name instead of the mangled one. The code was based on what @SamuraiOndo (@/z.berg in the GC decomp discord) had done a while ago (with her permission). The suggestion that encounter gave to pass the demangler as a field in CreateScratchConfig was implemented.
Not entirely sure if the way the demangler field is being passed by setting it to
state.effective_diff_config().demangleris correct. If it's not the best way to do it let me know and I can change that.