Skip to content

Update sdl2-config test. NFC #25961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Dec 16, 2025
Merged

Update sdl2-config test. NFC #25961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions emmake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ def run():
args[0] = mingw32_make

# On Windows, run the execution through shell to get PATH expansion and
# executable extension lookup, e.g. 'sdl2-config' will match with
# 'sdl2-config.bat' in PATH.
# executable extension lookup, e.g. 'make' will match with
# 'make.bat' in PATH.
print(f'emmake: "{shlex.join(args)}" in "{os.getcwd()}"', file=sys.stderr)
if utils.WINDOWS:
return utils.run_process(args, check=False, shell=True, env=env).returncode
Expand Down
2 changes: 1 addition & 1 deletion test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6310,7 +6310,7 @@ def test_sdl2_config(self):
[['--cflags', '--libs'], '-sUSE_SDL=2'],
]:
print(args, expected)
out = self.run_process([utils.bat_suffix(cache.get_sysroot_dir('bin/sdl2-config'))] + args,
out = self.run_process([cache.get_sysroot_dir('bin/sdl2-config')] + args,
stdout=PIPE, stderr=PIPE).stdout
self.assertContained(expected, out)
print('via emmake')
Expand Down