Native AOT support for NET8.0 and above.#78
Closed
Samael7777 wants to merge 1 commit intoemoacht:masterfrom
Closed
Native AOT support for NET8.0 and above.#78Samael7777 wants to merge 1 commit intoemoacht:masterfrom
Samael7777 wants to merge 1 commit intoemoacht:masterfrom
Conversation
…. Native AOT support for NET8.0 and above.
Owner
|
Thank you for the PR. That said, after some consideration, I have concluded that I cannot merge this PR. First, the commit of this PR is too big for review. Second, from a quick glance at a small portion of this commit, the changes seem to mix at least four different objectives and it is hard to tell which changes are essential to which.
Combining these makes this commit practically unreviewable. Mergining it as-is would comprimise the long-term maintanablity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transition to import code generation using CsWin32 without marshaling. Native AOT support for NET8.0 and above.