[GRX-123456] Adding missing Dip Switch Settings for Double Dragon 2#5
Open
[GRX-123456] Adding missing Dip Switch Settings for Double Dragon 2#5
Conversation
The Dip Switch settings were never added in FBbarr. These values come from MAME source code: https://github.com/mamedev/mame/blob/master/src/mame/drivers/ddragon.cpp#L663 Note: do not reference dip switch settings in original manual, because they are wrong!
emfloyd2
commented
Jun 28, 2018
| // reference, because it lists wrong settings! | ||
| // | ||
| // If anyone points you to bad settings from Manual | ||
| // they will look like this: |
Owner
Author
There was a problem hiding this comment.
[Nit]
Fix alignment of comments
| // OFF OFF = Normal | ||
| // OFF OFF = Easy | ||
| // ON OFF = Less Than Difficult | ||
| // ON ON = Difficult |
Owner
Author
There was a problem hiding this comment.
Add a link to original Manual if you can find it
emfloyd2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Dip Switch settings were never added in FBbarr. These
values come from MAME source code: https://github.com/mamedev/mame/blob/master/src/mame/drivers/ddragon.cpp#L663
Note: do not reference dip switch settings in original manual,
because they are wrong!
Why are we fixing this
As part of TAS project for Double Dragon 2, I need access to Dip Switch settings. Without these, TAS Runners are stuck doing runs on Medium [Default] Difficulty, which will not be a valid submission for TAS videos.
Ticket
http://loren-ipsum/GRX-123456
NOTES
For reference, here's image of the bad Dip Switch Settings in original Double Dragon 2 Hardware manual
Tests
All Dip Switch settings have been verified using RAM Watch (verified health point scaling)