Skip to content

backend: harden asset issuer handling#729

Merged
emdevelopa merged 1 commit into
emdevelopa:mainfrom
edehvictor:fix/asset-issuer-pooler-hardening-607
May 26, 2026
Merged

backend: harden asset issuer handling#729
emdevelopa merged 1 commit into
emdevelopa:mainfrom
edehvictor:fix/asset-issuer-pooler-hardening-607

Conversation

@edehvictor

@edehvictor edehvictor commented May 26, 2026

Copy link
Copy Markdown
Contributor

Closes #607
Closes #608
Closes #606
Closes #609

Changes

  • Resolve configured default issuers for standard non-native assets like USDC before allowlist checks and inserts.
  • Validate asset_issuer values as Stellar public keys in schema, route, service, and Stellar asset resolution paths.
  • Keep native XLM issuerless so issuer allowlists only apply to non-native assets.
  • Update focused schema/service tests and route test mocks for the new issuer validation helper.

Testing

  • git diff --check
  • node --check backend/src/lib/request-schemas.js
  • node --check backend/src/services/paymentService.js
  • node --check backend/src/routes/payments.js
  • node --check backend/src/lib/stellar.js
  • node --check backend/src/constants/assetConstants.js
  • node --check backend/src/lib/request-schemas.test.js
  • node --check backend/src/services/paymentService.test.js

Full test suite not run; dependencies were not installed per request.

@vercel

vercel Bot commented May 26, 2026

Copy link
Copy Markdown

@edehvictor is attempting to deploy a commit to the Emmanuel's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented May 26, 2026

Copy link
Copy Markdown

@edehvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@emdevelopa emdevelopa merged commit f7877b8 into emdevelopa:main May 26, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants