fix(core): remove FTS5 integrity-check to prevent D1 shadow table corruption#313
Open
mvanhorn wants to merge 2 commits intoemdash-cms:mainfrom
Open
fix(core): remove FTS5 integrity-check to prevent D1 shadow table corruption#313mvanhorn wants to merge 2 commits intoemdash-cms:mainfrom
mvanhorn wants to merge 2 commits intoemdash-cms:mainfrom
Conversation
…ruption The FTS5 integrity-check INSERT corrupts D1's shadow tables even when they are healthy, causing SQLITE_CORRUPT_VTAB on all content publishing. Row-count mismatch detection is retained as a safe alternative. Fixes emdash-cms#252 This contribution was developed with AI assistance (Codex).
🦋 Changeset detectedLatest commit: 22f262e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the FTS5
integrity-checkINSERT fromverifyAndRepairIndex()inpackages/core/src/search/fts-manager.ts. This command corrupts D1's FTS5 shadow tables on every Worker cold start, causing all content publishing to fail withSQLITE_CORRUPT_VTAB.The row-count mismatch check (Check 1) is retained -- it catches the most common corruption case without triggering D1's shadow table bug.
Closes #252
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Details
The root cause is at
fts-manager.ts:407:This FTS5 command is safe on standard SQLite but corrupts D1's shadow tables. Once corrupted, every content UPDATE fires FTS triggers that fail with
SQLITE_CORRUPT_VTAB, blocking all publishing across all collections.The fix removes the integrity-check entirely. The row-count mismatch check already handles the primary corruption case (count drift between content and FTS tables). The integrity-check was meant to catch subtle shadow table inconsistencies, but on D1 it causes the very corruption it was designed to detect.
Note: 3 pre-existing auth test failures on main (invite, magic-link, signup URL assertions) are unrelated to this change.
This contribution was developed with AI assistance (Codex).