Skip to content

Fix/show correct monthly cost#981

Open
talhak55 wants to merge 11 commits into
ellite:mainfrom
talhak55:fix/show-correct-monthly-cost
Open

Fix/show correct monthly cost#981
talhak55 wants to merge 11 commits into
ellite:mainfrom
talhak55:fix/show-correct-monthly-cost

Conversation

@talhak55
Copy link
Copy Markdown
Contributor

@talhak55 talhak55 commented Jan 13, 2026

Problem:
Monthly costs were misleadingly calculated by mixing yearly costs (divided by 12) with actual monthly costs.

Fix:

  • Separates pure monthly costs from yearly costs
  • Calculates and shows monthly cost only from actual monthly entries

Changes:

  • Updated cost calculation logic in [stats_calculations.php]
  • Updated translation method to pass an array of variables
  • Added subscription cards in [index.php]

Before
Bildschirmfoto 2026-01-13 um 14 47 37

After
Bildschirmfoto 2026-01-14 um 08 25 54

@talhak55 talhak55 marked this pull request as ready for review January 13, 2026 13:56
@talhak55 talhak55 marked this pull request as draft January 13, 2026 14:08
@talhak55 talhak55 marked this pull request as ready for review January 23, 2026 13:06
@ellite
Copy link
Copy Markdown
Owner

ellite commented Apr 27, 2026

Hi! Thank you for the contribution.
This is intended behaviour.
It's not the sum of all the monthly subscriptions. It's the ammount you need to pay, on average, per month.

@talhak55
Copy link
Copy Markdown
Contributor Author

talhak55 commented May 4, 2026

Hi! Thank you for the contribution. This is intended behaviour. It's not the sum of all the monthly subscriptions. It's the ammount you need to pay, on average, per month.

I'm aware of that, which is why I added extra cards showing the actual monthly cost rather than the average across all subscriptions. This is especially useful when users add one or more yearly subscriptions and need to calculate their real monthly expenses. My PR improves the readability of the true monthly cost view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants