Conversation
langmartin
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to come up w/a reasonable way to specify hibernate/shutdown behavior, I tripped over an interesting
GenServer"problem" :hibernate_after has a verifiable (but undocumented) interaction with things likehandle_call's implicittimeoutreturn value, first mentioned here.I was trying to allow for both being set (e.g. let the process sleep at the 15s mark, and snapshot/exit at the 60s mark), but the
hibernate_afterexpectation is never met (observable via:erlang.process_info(pid, :current_function)) as thetimeouts took precedent insteadhibernate_after. As a result, I settled on what is proposed asshutdown_policywhich is defined in the@moduledoc.Addresses #18