Fix crash when calling console.log(null)#1821
Closed
Sri Lakshmi Polavarapu (SriLakshmiPolavarapu) wants to merge 1 commit intoelide-dev:mainfrom
Closed
Fix crash when calling console.log(null)#1821Sri Lakshmi Polavarapu (SriLakshmiPolavarapu) wants to merge 1 commit intoelide-dev:mainfrom
Sri Lakshmi Polavarapu (SriLakshmiPolavarapu) wants to merge 1 commit intoelide-dev:mainfrom
Conversation
Sri Lakshmi Polavarapu (SriLakshmiPolavarapu)
requested a review
from Sam Gammon (sgammon)
as a code owner
Member
|
Hey Sri Lakshmi Polavarapu (@SriLakshmiPolavarapu), thank you for your PRs 🥳 this one has been fixed. Another contributor beat you to the punch by only a few days. That was merged, so this one will be closed, but your newer PR at #1844 looks great. Make sure to rebase that one so you gain the new fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1812
Calling console.log(null) could crash due to nullable varargs passed from JavaScript into Kotlin.
This change safely handles null arguments and logs "null" instead.