feat(node): crypto.createHash#1779
Closed
Elijah Kotyluk (ElijahKotyluk) wants to merge 8 commits intomainfrom
Closed
feat(node): crypto.createHash#1779Elijah Kotyluk (ElijahKotyluk) wants to merge 8 commits intomainfrom
crypto.createHash#1779Elijah Kotyluk (ElijahKotyluk) wants to merge 8 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
+ Coverage 42.64% 42.67% +0.03%
==========================================
Files 897 898 +1
Lines 38473 38534 +61
Branches 5989 6005 +16
==========================================
+ Hits 16405 16444 +39
- Misses 19845 19860 +15
- Partials 2223 2230 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
crypto.createHash
a947c0f to
ab5e578
Compare
Signed-off-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
Signed-off-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
Signed-off-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
- Allow digest() to be invoked with zero arguments from JS (fixes arity mismatch error) - Default to returning a ByteArray when no encoding is provided - Normalize encoding values and ensure lowercase comparisons - Aligns NodeHash behavior with Node.js crypto.Hash This fixes guest tests that are calling `hash.digest()` without arguments. Signed-off-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
Signed-off-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
…is passed. - Expand test coverage on digest method - Validate string check with Value type argument is working as expected in both host and guest Signed-off-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
…ate with test. Signed-off-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
ab5e578 to
a0a7817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Node.js Hash.
createHashmethodNodeHashclassNodeHash.update()methodNodeHash.clone()methodNodeHash.digest()methodChangelog
1.0