Tooltip: use background color from stylesheet and add text shadow#2811
Open
Tooltip: use background color from stylesheet and add text shadow#2811
Conversation
lenemter
force-pushed
the
lenemter/tooltip-improvements
branch
from
e917b17 to
9af734e
Compare
lenemter
force-pushed
the
lenemter/tooltip-improvements
branch
from
9af734e to
63043da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new background color for tooltips was taken from the stylesheet
For the text shadow, I implemented BoxShadowEffect since box blur is very cheap, and text shadows don't need to be pixel-perfect anyway
Currently, the effect can be added via Gala.BoxBlurManager, but I plan to remove it once I figure out how to properly implement #2776 :)