ReleasesDialog: Make listbox no select#2429
Merged
danirabbit merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
We don't want to select anything and this removes the weird selection highlight.
danirabbit
approved these changes
Mar 10, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This seems fine. We don't need selection here and afaict this leaves the list keyboard navigable which we need for the screen reader.
To actually fix the selection highlight style though we probably need to add some custom CSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to select anything and this removes the weird selection highlight.