Skip to content

feat: Port SignatureListItem to Rust#19754

Open
kaylendog wants to merge 4 commits intodevelopfrom
kaylendog/e2e-keys/signature-list-item
Open

feat: Port SignatureListItem to Rust#19754
kaylendog wants to merge 4 commits intodevelopfrom
kaylendog/e2e-keys/signature-list-item

Conversation

@kaylendog
Copy link
Copy Markdown

@kaylendog kaylendog commented May 5, 2026

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@kaylendog kaylendog self-assigned this May 5, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 5, 2026

CLA assistant check
All committers have signed the CLA.

@kaylendog kaylendog force-pushed the kaylendog/e2e-keys/signature-list-item branch from 31459f5 to 283728c Compare May 6, 2026 10:46
Comment thread synapse/synapse_rust/e2e_keys.pyi Outdated
@kaylendog kaylendog force-pushed the kaylendog/e2e-keys/signature-list-item branch 2 times, most recently from 8de04f2 to 0fcf561 Compare May 6, 2026 11:09
@kaylendog kaylendog force-pushed the kaylendog/e2e-keys/signature-list-item branch from 0fcf561 to cb23c90 Compare May 6, 2026 11:10
@kaylendog kaylendog marked this pull request as ready for review May 6, 2026 11:10
@kaylendog kaylendog requested a review from a team as a code owner May 6, 2026 11:10
Comment thread rust/src/e2e_keys/mod.rs Outdated
#[pyclass(frozen)]
pub struct SignatureListItem {
/// Full key ID of the signing key, e.g. `"ed25519:ABCDEF"`.
#[pyo3(get)]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by: FYI you can use #[pyclass(frozen, get_all)] to automatically add #[get] to all fields. There is also a new = "from_fields", but I haven't used it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like the new attribute is part of 0.28.0, so would need to bump the version. Best done in a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants