Fix type hints for modify_in_place overloads in Dataset#171
Merged
Conversation
Collaborator
Author
|
@gvarnavi let me know if this makes sense to you as i know you've played with static type checkers quite a bit. |
gvarnavi
approved these changes
Feb 4, 2026
Collaborator
gvarnavi
left a comment
There was a problem hiding this comment.
lgtm, and makes my type-hinter happy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes type hints for
Dataset, specifically to do with the overloading ofDataset.crop()andDataset.bin()andmodify_in_place:bool.Previously,
.crop()->Datasetno matter what, leading to issues:Now with the fix, everything works as expected.

There are 2 other main types of change in the file:
np.isscalar(val)toisinstance(val, float|int)which is better handled by static type checkersdataset.pyin a few places due to line lengths--not sure why that hadn't happened previouslyAlso, I'm not quite sure why, but
reveal_typefromtypingwas actually working okay even with the old version... and this fix doesn't break it or anything so there's no problems there.