Dataset5dstem - stack reduction, slicing, Nion Swift, match Dataset4dstem API convention#151
Draft
bobleesj wants to merge 12 commits intoelectronmicroscopy:devfrom
Draft
Dataset5dstem - stack reduction, slicing, Nion Swift, match Dataset4dstem API convention#151bobleesj wants to merge 12 commits intoelectronmicroscopy:devfrom
Dataset5dstem - stack reduction, slicing, Nion Swift, match Dataset4dstem API convention#151bobleesj wants to merge 12 commits intoelectronmicroscopy:devfrom
Conversation
- Add docstring with examples to from_array() - Add docstring with examples to from_shape() - Use "Frame N" as default title (appropriate for time series/tomography) - Add suptitle parameter with proper layout adjustment
…ng, and virtual imaging
…U error, slicing metadata fix
- Add show() that raises NotImplementedError with helpful message - Add show_virtual_images(), regenerate_virtual_images(), update_virtual_detector(), clear_virtual_images(), clear_all_virtual_data() - Add from_file() classmethod - Support auto-fit center per frame with geometry=(None, radius) - Support per-frame geometry with list of geometries - Add __str__ and __repr__ to Dataset4dstem for consistency - Add tests for all new features
- Add geometry=None support for full auto-detection (center + radius) - Update Dataset4dstem docstring: scan_y/x -> scan_row/col, dp_y/x -> k_row/col - Add test for full auto-detection virtual imaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #149
Adds Dataset5dstem class for 5D-STEM data (time series, tilt series, dose fractionation, etc.).
What should the PR reviewer do?
This PR is built atop of #150.
Demo:
Prints
I will ask for review @gvarnavi after #150 merged and share a notebook.