fix: show trigger action after markdown finishes typing#1474
Merged
4pmtong merged 2 commits intoeigent-ai:mainfrom Mar 16, 2026
Merged
fix: show trigger action after markdown finishes typing#14744pmtong merged 2 commits intoeigent-ai:mainfrom
4pmtong merged 2 commits intoeigent-ai:mainfrom
Conversation
4pmtong
approved these changes
Mar 16, 2026
Collaborator
4pmtong
left a comment
There was a problem hiding this comment.
LGTM. Thanks @kiannidev for contribution
bitloi
pushed a commit
to bitloi/eigent
that referenced
this pull request
Mar 18, 2026
Co-authored-by: root <root@dragon.second> Co-authored-by: Tong Chen <web_chentong@163.com>
a7m-1st
reviewed
Mar 31, 2026
Collaborator
a7m-1st
left a comment
There was a problem hiding this comment.
Thanks @kiannidev & @4pmtong !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1405.
Summary
isCompletionReadyflag inUserQueryGroupthat is set only when the ENDAgentMessageCard’s typewriter completes.TaskCompletionCardrendering on bothtask.status === 'finished'andisCompletionReady, so the UI no longer shows trigger actions while the markdown answer is still typing.Implementation details
src/components/ChatBox/UserQueryGroup.tsx:isCompletionReadywith local state and reset when the active task or query group changes.onTypingto the ENDAgentMessageCardto setisCompletionReadywhen itsMarkDowntypewriter finishes.TaskCompletionCardonly whentask.status === 'finished' && isCompletionReady.Testing