resolve #465 update query on mutation success shorthand#469
Open
xaota wants to merge 2 commits intoeffector:masterfrom
Open
resolve #465 update query on mutation success shorthand#469xaota wants to merge 2 commits intoeffector:masterfrom
xaota wants to merge 2 commits intoeffector:masterfrom
Conversation
igorkamyshev
requested changes
Apr 6, 2024
Member
igorkamyshev
left a comment
igorkamyshev
left a comment
There was a problem hiding this comment.
Thanks for the contribution 🙏
- Please add changeset by instruction in README. It will be used to determine the next version of the library and would be filled to CHANGELOG.
- Please mark your changes in docs. At least in API ref with a mention that this overload is available since the next minor release (0.13 I assume).
- I see runtime-tests for the change, but I do not see any type-test. Could you add it to ensure your changes are working correctly with TS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.