fix: contract jsinput html_file asset URLs to /static/ on save (LP-704)

src/editors/sharedComponents/TinyMceWidget/hooks.test.js

@@ -227,6 +227,35 @@ describe('TinyMceEditor hooks', () => {
         const content = module.setAssetToStaticUrl({ editorValue, lmsEndpointUrl });
         expect(content).toEqual('<img src="/static/goku.img"/> <a href="/static/goku.img">testing link</a>');
       });
+      it('returns content with updated jsinput html_file links', () => {
+        const editorValue = `<jsinput html_file="/${baseAssetUrl}@textlog.html" gradefn="getGrade"/>`;
+        const lmsEndpointUrl = getConfig().LMS_BASE_URL;
+        const content = module.setAssetToStaticUrl({ editorValue, lmsEndpointUrl });
+        expect(content).toEqual('<jsinput html_file="/static/textlog.html" gradefn="getGrade"/>');
+      });
+      it('returns content with updated jsinput html_file links when URL is absolute', () => {
+        const lmsEndpointUrl = getConfig().LMS_BASE_URL;
+        const editorValue = `<jsinput html_file="${lmsEndpointUrl}/${baseAssetUrl}@textlog.html" gradefn="getGrade"/>`;
+        const content = module.setAssetToStaticUrl({ editorValue, lmsEndpointUrl });
+        expect(content).toEqual('<jsinput html_file="/static/textlog.html" gradefn="getGrade"/>');
+      });
+      it('returns content with updated jsinput html_file links using encoded quotes', () => {
+        const editorValue = `<jsinput html_file=&quot;/${baseAssetUrl}@textlog.html&quot; gradefn=&quot;getGrade&quot;/>`;
+        const lmsEndpointUrl = getConfig().LMS_BASE_URL;
+        const content = module.setAssetToStaticUrl({ editorValue, lmsEndpointUrl });
+        expect(content).toEqual('<jsinput html_file=&quot;/static/textlog.html&quot; gradefn=&quot;getGrade&quot;/>');
+      });
+      it('does not strip the literal text "undefined" when lmsEndpointUrl is not provided', () => {
+        const editorValue = `<p>value may be undefined</p><img src="/${baseAssetUrl}@soME_ImagE_URl1"/>`;
+        const content = module.setAssetToStaticUrl({ editorValue });
+        expect(content).toEqual('<p>value may be undefined</p><img src="/static/soME_ImagE_URl1"/>');
+      });
+      it('returns content with updated href links using encoded quotes', () => {
+        const editorValue = `<a href=&quot;/${baseAssetUrl}@soMEImagEURl&quot;>testing link</a>`;
+        const lmsEndpointUrl = getConfig().LMS_BASE_URL;
+        const content = module.setAssetToStaticUrl({ editorValue, lmsEndpointUrl });
+        expect(content).toEqual('<a href=&quot;/static/soMEImagEURl&quot;>testing link</a>');
+      });
     });
 
     describe('editorConfig', () => {

src/editors/sharedComponents/TinyMceWidget/hooks.ts

@@ -510,10 +510,13 @@ export const setAssetToStaticUrl = ({ editorValue, lmsEndpointUrl }) => {
 
   // TODO: should probably move this to when the assets are being looped through in the off chance that
   // some of the text in the editor contains the lmsEndpointUrl
-  const regExLmsEndpointUrl = RegExp(lmsEndpointUrl, 'g');
-  let content = editorValue.replace(regExLmsEndpointUrl, '');
+  let content = editorValue;
+  if (lmsEndpointUrl) {
+    const escapedLmsEndpointUrl = lmsEndpointUrl.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+    content = content.replace(RegExp(escapedLmsEndpointUrl, 'g'), '');
+  }
 
-  const assetSrcs = typeof content === 'string' ? content.split(/(src="|src="|href="|href=&quot)/g) : [];
+  const assetSrcs = typeof content === 'string' ? content.split(/(src="|src="|href="|href="|html_file="|html_file=")/g) : [];
   assetSrcs.filter(src => src.startsWith('/asset')).forEach(src => {
     const nameFromEditorSrc = parseAssetName(src);
     const portableUrl = getStaticUrl({ displayName: nameFromEditorSrc });