Add AWS Bedrock Converse/ConverseStream provider support #255
+519
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements full support for AWS Bedrock's Converse and ConverseStream APIs in ECA.
Key Features:
- Standard chat completions via Converse API
- Streaming responses via ConverseStream API
- Full tool use support with proper formatting
- Custom binary event stream parser (no AWS SDK required)
- Bearer token authentication via external proxy
- Model aliasing for convenience
- Support for additional model parameters (e.g., top_k, topP)
Implementation Details:
- Uses hato.client for HTTP requests (consistent with other providers)
- Custom binary stream parser following AWS Event Stream protocol
- Proper CRC checksum handling for streaming responses
- Comprehensive error handling and logging
Testing:
- 8 tests covering all major functionality (17 assertions)
- Tool use workflows
- Binary stream parsing
- Response parsing
- Payload building
Configuration Example:
```clojure
{:providers
{:bedrock
{:api "bedrock"
:key "${env:BEDROCK_API_KEY}"
:url "https://proxy.example.com/model/{modelId}/converse"
:region "us-east-1"
:models {:claude-3-sonnet
{:modelName "anthropic.claude-3-sonnet-20240229-v1:0"}}}}}
```
Usage:
```clojure
;; Standard request
(provider/request bedrock-config messages {:temperature 0.5 :top_k 200})
;; With tools
(provider/request bedrock-config messages {:tools [tool-spec] :temperature 0.7})
;; Streaming
(provider/request bedrock-stream-config messages {:temperature 0.7})
```
Files Changed:
- src/eca/llm_api.clj: Added require for aws-bedrock provider
- src/eca/llm_providers/aws_bedrock.clj: New provider implementation
- test/eca/llm_providers/aws_bedrock_test.clj: Comprehensive test suite
- AWS_BEDROCK_EXAMPLE.md: Usage documentation
This implementation follows the established patterns in the codebase and is ready for production use.
🤖 Generated with [eca](https://eca.dev)
Co-Authored-By: eca <[email protected]>
CsBigDataHub
force-pushed
the
feature/support-aws-bedrock-provider
branch
from
d8a767c to
08948b1
Compare
Contributor
Author
|
Future feature request - This Implementation uses Bearer token retrieved externally but we can support AWS Bedrock requires SigV4 signing. Right now I have python code to perform single sign on and retrieve the token which I intend to use here. See here - karthink/gptel#1200 (comment) We can add AWS SigV4 signing directly (using a library like cognitect/aws-api) but we need to add aws library. I have conflicting thoughts on this one. |
Contributor
Author
|
Maybe we can leverage this after merge - #249. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ericdallo,
This commit implements full support for AWS Bedrock's Converse and ConverseStream APIs in ECA.
Key Features:
Implementation Details:
Testing:
Files Changed:
Will add to add to the changelog once I am able to test, my company proxy and cloudflare seems to be blockers at this point.