Skip to content

Replace arc-swap by hazarc#2470

Closed
wyfo wants to merge 1 commit into
eclipse-zenoh:mainfrom
ZettaScaleLabs:hazarc
Closed

Replace arc-swap by hazarc#2470
wyfo wants to merge 1 commit into
eclipse-zenoh:mainfrom
ZettaScaleLabs:hazarc

Conversation

@wyfo

@wyfo wyfo commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Description

Replace arc-swap with hazarc

What does this PR do?

Replace arc-swap with hazarc

Why is this change needed?

hazarc has better performance characteristic, especially regarding loading of None and is more robustly tested.

Related Issues

None


🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: dependencies, internal

📦 Dependency Updates

Since this PR updates dependencies:

  • Changelog reviewed - Breaking changes in dependency identified and addressed
  • Security advisories checked - No known vulnerabilities in new version
  • License compatible - New version license is compatible with project
  • Tests pass - All tests pass with new dependency versions
  • Transitive deps reviewed - New transitive dependencies checked
  • Version pinned appropriately - Semver range is intentional and correct
  • Update scope limited - Updating one major dependency at a time when possible

Best practice: Keep dependency updates focused and test thoroughly.

🏠 Internal Change

This PR is marked as internal (not user-facing):

  • No API changes - Public APIs unchanged
  • No behavior changes - External behavior identical
  • Refactoring/maintenance - Code improvements only
  • Tests still pass - All existing tests pass without modification

Lighter review: Internal changes may have lighter review requirements.

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

hazarc has better performance characteristic, especially regarding loading of `None`
and is more robustly tested.
@wyfo wyfo requested a review from fuzzypixelz March 10, 2026 10:18
@wyfo wyfo added dependencies Pull requests that update a dependency file internal Changes not included in the changelog labels Mar 10, 2026
@wyfo

wyfo commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

This was a vibe-coded experiment, but it was faster, with better result to do it by hand... Superseded by #2472

@wyfo wyfo closed this Mar 10, 2026
@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.78261% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.53%. Comparing base (9f8dff1) to head (98eb442).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
zenoh/src/net/routing/dispatcher/face.rs 70.96% 9 Missing ⚠️
zenoh/src/net/primitives/mux.rs 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2470      +/-   ##
==========================================
- Coverage   72.60%   72.53%   -0.08%     
==========================================
  Files         390      390              
  Lines       63374    63372       -2     
==========================================
- Hits        46015    45965      -50     
- Misses      17359    17407      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file internal Changes not included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant