Merged
Conversation
Motivation: The new stateless VertxTestBase mode allows to spot incorrect assertions, when a test is migrated we would like to ensure AsyncTestBase assertions are never called anymore. This is useful to prevent regression until the effort is completed. Changes: Turn the boolean config into an enum with a FORBIDDEN mode always fail on thread checks.
vietj
force-pushed
the
add-vertx-test-base-report-mode
branch
from
be54be8 to
11c98fb
Compare
Some portions of this content were created with the assistance of Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The new stateless
VertxTestBasemode allows to spot incorrect assertions, when a test is migrated we would like to ensureAsyncTestBaseassertions are never called anymore.This is useful to prevent regression until the effort is completed.
Changes:
Turn the boolean config into an enum with a
FORBIDDENmode always fail on thread checks.