[2111] Improve stakeholder creation tool using the latest selection dialog changes#2118
Open
[2111] Improve stakeholder creation tool using the latest selection dialog changes#2118
Conversation
AxelRICHARD
reviewed
Apr 8, 2026
| .verify(Duration.ofSeconds(10)); | ||
| } | ||
|
|
||
| @GivenSysONServer({ GeneralViewWithTopNodesTestProjectData.SCRIPT_PATH }) |
Member
There was a problem hiding this comment.
Description is missing, here and below
Member
Author
There was a problem hiding this comment.
By description, you mean the @DisplayName?
| Objects.requireNonNull(self); | ||
| Objects.requireNonNull(selectedObject); | ||
|
|
||
| if ((self instanceof RequirementUsage || self instanceof RequirementDefinition) && (selectedObject instanceof ItemUsage || selectedObject instanceof ItemDefinition)) { |
Member
There was a problem hiding this comment.
I don't understand why you remove this part "&& (selectedObject instanceof ItemUsage || selectedObject instanceof ItemDefinition)"
Member
Author
There was a problem hiding this comment.
Because with the support of the selection dialog, selectedObject can be null.
So the new behavior creates a Stakeholder no matter what, and if the selected object is an instance of ItemUsage or ItemDefinition, then this service creates a subsetting or a feature typing
|
|
||
| ** Add tools to create timeslices and snapshots, available on `OccurrenceUsage`, `ItemUsage`, and `PartUsage` graphical nodes. | ||
| These tools leverage a selection dialog to either create a specific timeslice/snapshot graphical node or, if no selection is made, default to a timeslice/snapshot `OccurrenceUsage` graphical node. | ||
| ** Improve the tool to create a stakeholder graphical node by making specialization selection optional. |
gcoutable
force-pushed
the
gco/enh/new-stakeholder-selection-dialog
branch
from
458bcc5 to
d94d7ec
Compare
…ialog changes Bug: #2111 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable
force-pushed
the
gco/enh/new-stakeholder-selection-dialog
branch
from
d94d7ec to
4311241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #2111
Signed-off-by: Guillaume Coutable guillaume.coutable@obeo.fr
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests