feat(LicenseInfo): enrich parsed licenses with LicenseDB obligations - #4439
Conversation
e426474 to
7774be7
Compare
|
small note: the Licensedb obligation id key is written directly here. i kept it this way to avoid adding extra dependency from another module but i can move it to a shared constant if needed. |
|
@GMishx i m not 100% sure if this is exactly the flow you had in mind,but my understanding was to refresh licensedb managed obligations from couchdb during cli enrichment similar to the license text flow. happy to adjust if you suggest a better approach. |
| Set<ObligationAtProject> enrichedObligations = new HashSet<>(); | ||
| for (Obligation obligation : obligations) { | ||
| if (obligation.getExternalIds() == null | ||
| || !obligation.getExternalIds().containsKey("licensedb-ob-id")) { |
There was a problem hiding this comment.
Please use constants like LicenseDBDataMapper.EXTERNAL_ID_LICENSEDB_OB
licenses-core can be made part of this module if it is not breaking any other module. If there are breakages, move it as a constant of this class.
There was a problem hiding this comment.
licenses-core isnt a dependency of the licenseinfo module so so defined the constant locally
Yes, this is exactly what we discussed on Tuesday 👍 |
7774be7 to
bb51131
Compare
2 participants
Summary
Enriches CLI license obligations from SW360/CouchDB when LicenseDB integration is enabled.
Changes
licensedb-ob-id.Suggested Reviewers
@GMishx
@deo002
@Farooq-Fateh-Aftab