Skip to content

refactor(search): migrate moderation request search to new infra - #4432

Merged
GMishx merged 3 commits into
eclipse-sw360:feat/search/reworkfrom
siemens:feat/search/mr
Aug 6, 2026
Merged

refactor(search): migrate moderation request search to new infra#4432
GMishx merged 3 commits into
eclipse-sw360:feat/search/reworkfrom
siemens:feat/search/mr

Conversation

@deo002

@deo002 deo002 commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Moved moderation request search to new infra.
  • Add sort functionality.

How To Test?

Make a curl request to the GET /moderationrequest endpoint and ensure only relevant results are found.

curl -X 'GET' \
  'http://localhost:8080/resource/api/moderationrequest?page=0&page_entries=10&sort=name%2Cdesc&type=RELEASE&luceneSearch=true' \
  -H 'accept: application/vnd.hal+json' \
  -H 'Authorization: Basic abc'

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@deo002
fix(search): support building queries from a set of strings
d2d8754 
Signed-off-by: Dearsh Oberoi <oberoidearsh@gmail.com>
@deo002
deo002 force-pushed the feat/search/mr branch 2 times, most recently from 27ca05f to 333d764 Compare August 6, 2026 09:03
GMishx
GMishx requested changes Aug 6, 2026
View reviewed changes
Comment thread ...a/org/eclipse/sw360/rest/resourceserver/moderationrequest/Sw360ModerationRequestService.java Outdated
Comment thread ...a/org/eclipse/sw360/rest/resourceserver/moderationrequest/Sw360ModerationRequestService.java Outdated
Comment thread ...a/org/eclipse/sw360/rest/resourceserver/moderationrequest/Sw360ModerationRequestService.java Outdated
Comment thread ...a/org/eclipse/sw360/rest/resourceserver/moderationrequest/Sw360ModerationRequestService.java Outdated
@deo002
deo002 requested a review from GMishx August 6, 2026 10:22
@deo002
refactor(search): migrate moderation request search to new infra
bb1b154 
Signed-off-by: Dearsh Oberoi <oberoidearsh@gmail.com>
GMishx
GMishx approved these changes Aug 6, 2026
View reviewed changes

@GMishx GMishx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx
feat(obligations): fix pagination for obligations
93b59c4 
1. Fix the pagination for the `/obligations` endpoint. Now all kind of
  search return paginated data.
2. Use moderation state as "open", "closed" or "all" to match `/byState`
  endpoint behaviour.
3. Document the `requestDate` parameter usage.
4. Remove unused functions from the moderation.thrift and
  Sw360ModerationRequestService.java

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
GMishx
GMishx approved these changes Aug 6, 2026
View reviewed changes

@GMishx GMishx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx
GMishx merged commit 036114c into eclipse-sw360:feat/search/rework Aug 6, 2026
3 checks passed
@GMishx
GMishx deleted the feat/search/mr branch August 6, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMishx GMishx GMishx approved these changes
@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner
@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner
@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner
@rudra-superrr rudra-superrr Awaiting requested review from rudra-superrr rudra-superrr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deo002 @GMishx