refactor: replaced @Autowired annotations with constructor injections - #4425
refactor: replaced @Autowired annotations with constructor injections #4425honeyverma1 wants to merge 9 commits into
Conversation
honeyverma1
changed the title
|
@honeyverma1 , please follow the conventional commit messages. Your CI is failing. |
noted sir. should I try to change the commit messages ?? |
|
regarding, Error: 🚫 According to the conventional-commits specification, some of the commit messages are not valid. |
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.36.2 to 4.37.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) --- updated-dependencies: - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ed Contructor injections. Signed-off-by: honeyverma1 <honeyverma8240@gmail.com>
…ented constructor injections
67c6379 to
f5d8e8d
Compare
|
@GMishx sir I have changed the commit messages and ensured every message follows the convention (in my best understanding), moreover I have force-pushed the changed commits. please can you verify again |
|
@GMishx sir I found that the tests were failing because I removed @Autowired from a method of class Sw360AuthorizationServerConfiguration. The function that was autowired is never called and neither is a constructor, hence I figured that the method needs to be annotated for it to configure the Authentication Manager. Please review |
|
Moreover @GMishx sir, I am facing some abnormalities in configuring the couchdb-tests.properties in datahandler package. The issue I noticed was that the couchdb-test.properties from the build-configuration test JAR was never getting unpacked into libraries/datahandler/target/test-classes. Moreover I re-installed maven multiple times still had to manually copy it into the expected location. can you please give me an insight on this as well ?? |
|
hello @GMishx , i believe all the test have passed and the PR is ready to be merged. please verify |
2 participants
Summary
@Autowiredannotations from classes with a single constructor.Verification