Clean permissions of workflows and enable coverage reporting for PRs#152
Draft
LittleHuba wants to merge 12 commits intomainfrom
Draft
Clean permissions of workflows and enable coverage reporting for PRs#152LittleHuba wants to merge 12 commits intomainfrom
LittleHuba wants to merge 12 commits intomainfrom
Conversation
LittleHuba
force-pushed
the
ulhu_add_perms_to_workflows
branch
from
e1c1fdf to
a1d1bb3
Compare
LittleHuba
force-pushed
the
ulhu_add_perms_to_workflows
branch
3 times, most recently
from
8250eb4 to
a69ada7
Compare
The new S-CORE GCC toolchain requires a very specific host platform to be manually selected. This is not suitable for our default toolchain setup. Therefore, we move this toolchain to a specific configuration and use an opensource GCC toolchain as alternative.
Manually specifying the host platform can lead to tremendous problems if the specified host platform does match the actual platform. Removes the selection to let Bazel automatically select the appropriate host platform.
Reduce the permissions of all workflows as far as possible. Further, actively specify permissions as action to the codeql findings. This also enables us to run the coverage report workflow on PRs.
Makes workflow more versatile to support testing more toolchains.
These targets fail with the QNX toolchains. Since both targets are about documentation, fixing this has very low priority.
Many of the integration tests had race conditions. Most expected that the service is there once the client searches for it. But there was no synchronization between the skeleton offer being made available and the client doing a one-time FindService call. Switches to StartFindService to effectively synchronize the service discovery.
StartFindService does not provide incremental updates of new service offers. Instead, it gives the full list of existing service offers at that current moment. User applications must filter out the diff on their own. Uses an unordered_map to correctly filter for individual service offers.
LittleHuba
force-pushed
the
ulhu_add_perms_to_workflows
branch
from
a69ada7 to
4a6af2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the permissions of all workflows as far as possible. Further, actively specify permissions as action to the codeql findings.
This also enables us to run the coverage report workflow on PRs.