Skip to content

minor fix to allow either INPFC or ks statification #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandynlucca merged 1 commit into from
May 21, 2026
Merged

minor fix to allow either INPFC or ks statification #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion echopop/inversion/inversion_length_TS.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def get_stratified_sigma_bs(
df_length_counts["sigma_bs"] = 10.0 ** (df_length_counts["TS"] / 10.0)

# Aggregate by stratum
self.sigma_bs_strata = df_length_counts.groupby(["stratum_ks"])[
self.sigma_bs_strata = df_length_counts.groupby(self.model_params["stratify_by"])[

@rebeccathomas-NOAA rebeccathomas-NOAA May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little comment - hi!

@leewujung leewujung May 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lala

@rebeccathomas-NOAA rebeccathomas-NOAA May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi

@LOCEANlloydizard LOCEANlloydizard May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello !

["length_count", "sigma_bs"]
].apply(lambda x: np.average(x.sigma_bs, weights=x.length_count))

Expand Down
Loading