Experiment: Tables in rich text#4836
Closed
carlobeltrame wants to merge 1 commit into
Closed
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
3986d64 to
94c27b6
Compare
Contributor
|
Can we close this PR? |
Member
Author
|
Yes, for now I'm not working on this actively. I think the following limitations were still present:
The first two should be solvable if react-pdf switches from yoga to a layout engine like DioxusLabs/taffy which has flexbox as well as grid support (maybe one day even table layout support). They are working on WASM bindings DioxusLabs/taffy#394 and I was experimenting with it to replace yoga in react-pdf, but it's still in the early stages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just playing around a little... And nuxt print is broken locally, so I want the feature branch deployment to see something 😬
One bug I which has to be investigated still: The horizontal space allocation in client print is different depending on whether you print the whole camp (in camp admin) or just a single activity (from the activity detail view):
Printing the activity from camp admin:

Printing the same activity from the activity detail view:
