This repository was archived by the owner on Jun 1, 2018. It is now read-only.
Better store detection by list ID taking into account scope inheritance#155
Open
unicoder88 wants to merge 1 commit into
Open
Better store detection by list ID taking into account scope inheritance#155unicoder88 wants to merge 1 commit into
unicoder88 wants to merge 1 commit into
Conversation
Contributor
|
Hello @unicoder88 Thanks for your contribution, we will review it as soon as possible. Regards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we had to override getStoreByList helper function in order to make it work better for scope inheritance cases, for example when list is selected in default scope, and only overriden for one store view (say, English).
How would this fit upstream release?