[#24061] Updated read_next_command() for the new FastDDS-Spy filter

[Danipiza]

Added new function:

std::vector<std::string> join_quoted_strings(
        const std::vector<std::string>& input);

This function is used in read_next_command(Command<CommandEnum>& command) to join quotes in a single argument. Used in FastDDS-Spy filter by topic (Content Filtered Topic)

read_next_command() it is only used in FastDDS-Spy.
https://github.com/search?q=org%3AeProsima%20read_next_command(&type=code

Example

// command = filter set topic HelloWorldTopic "index > 10" 

Before: ["filter", "set", "topic", "HelloWorldTopic", "\"index", ">", "10\"" ] // Size: 7
After:  ["filter", "set", "topic", "HelloWorldTopic", "index > 10" ] // Size: 5

[codecov-commenter]

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (306edca) to head (4c87039).

Files with missing lines	Patch %	Lines
...de/cpp_utils/user_interface/impl/CommandReader.ipp	30.76%	6 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   60.43%   60.21%   -0.22%     
==========================================
  Files          65       65              
  Lines        1921     1933      +12     
  Branches      543      552       +9     
==========================================
+ Hits         1161     1164       +3     
- Misses        440      447       +7     
- Partials      320      322       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rsanchez15]

Review the case when the command does not have closing "

[rsanchez15]

Is this part of the new uncrustify?

[Danipiza]

No. I have applied uncrustify again and the space has being removed.

[rsanchez15]

Suggested change

	// Check if the last character in the joined string is
	// a closed quote (") or not. If it is a closed quote
	// remove it from the string (value = 2)
	// otherwise keep all the string (value = 1)
	// Check if the last character in the joined string is
	// a closing quote (") or not. If it is a closing quote
	// remove it from the string (value = 2)
	// otherwise keep all the string (value = 1)

[Danipiza]

Done in 4c87039

[rsanchez15]

Suggested change

	} /* namespace utils */
	} /* namespace utils */

[Danipiza]

Done in 4c87039

[rsanchez15]

LGTM