Use localtime_r instead of localtime#381
Conversation
localtime is not reentrant.
There was a problem hiding this comment.
This should use with-storage ... you can get the size from a call into C, I guess (or another magic constant), but a define constant $tm-size = primitive-whatever(%call-c-function("dylan_sizeof_tm") ... ); shouldn't be that bad.
There was a problem hiding this comment.
(And I know that with-storage uses GC_malloc ... that's something that will change later.)
|
In addition to the comments on the code, I'm hoping that we can be better with release notes going forward ... so a release note addition, including what Dylan level stuff this impacts would be nice. |
|
Hmm, given the structure if the surrounding code, I see why it is this way and not with-structure... |
|
Test FAILed. |
3 participants
localtime is not reentrant.