Open
Conversation
fastbodin
force-pushed
the
enhancement/reducenode_cache_sizeinfo
branch
from
cab78f1 to
c47e836
Compare
Contributor
Author
|
|
`ReduceNode` (and therefore the symbols: `All`, `Any`, `Max`, `Min`, `Prod`, and `Sum`) can infer size from predecessor's size.
fastbodin
force-pushed
the
enhancement/reducenode_cache_sizeinfo
branch
from
c47e836 to
c5d2e0f
Compare
wbernoudy
reviewed
Feb 26, 2026
| std::span<const ssize_t> axes) { | ||
| // Node is statically sized. Note: If node_shape = {}, product(node_shape) = 1. | ||
| if (!node_ptr->dynamic()) return SizeInfo(product(node_ptr->shape())); | ||
| assert(node_ptr->shape().size() && node_ptr->shape().front() == -1); |
Member
There was a problem hiding this comment.
Suggested change
| assert(node_ptr->shape().size() && node_ptr->shape().front() == -1); | |
| assert(node_ptr->shape().size() and node_ptr->shape().front() == -1); |
Contributor
Author
There was a problem hiding this comment.
If so, shouldn't the ! above be a not?
wbernoudy
reviewed
Feb 26, 2026
| if (!node_ptr->dynamic()) return SizeInfo(product(node_ptr->shape())); | ||
| assert(node_ptr->shape().size() && node_ptr->shape().front() == -1); | ||
|
|
||
| // Node is dynamically sized but predecessor is always empty. |
Member
There was a problem hiding this comment.
I would add a bit more detail here, something like "this means we can't easily make any deductions about the resulting size as it likely depends on predecessors of the input array" (assuming that's correct).
wbernoudy
reviewed
Feb 26, 2026
| --- | ||
| features: | ||
| - | | ||
| The symbol: `All`, `Any`, `Max`, `Min`, `Prod`, and `Sum` can infer |
Member
There was a problem hiding this comment.
Suggested change
| The symbol: `All`, `Any`, `Max`, `Min`, `Prod`, and `Sum` can infer | |
| The symbols `All`, `Any`, `Max`, `Min`, `Prod`, and `Sum` can infer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReduceNodecan now infer when its size is a function of its predecessor's size.