TransposeNode::propagate() improvements#479
Open
fastbodin wants to merge 1 commit intodwavesystems:mainfrom
Open
TransposeNode::propagate() improvements#479fastbodin wants to merge 1 commit intodwavesystems:mainfrom
TransposeNode::propagate() improvements#479fastbodin wants to merge 1 commit intodwavesystems:mainfrom
Conversation
fastbodin
changed the title
TransposeNode propagate improvements
fastbodin
changed the title
TransposeNode propagate improvementsTransposeNode::propagate() improvements
`TransposeNode::convert_predecessor_index()` recomputed the same information (the number of indices of the predecessor node traversed by taking a stride along an axis) for each update. Since this node is already extremely lightweight (its buffer is simply its predecessor's buffer), we can easily cache this data.
fastbodin
force-pushed
the
enhancement/transposenode_convert_predecessor_index
branch
from
ab2b583 to
5768e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransposeNode::convert_predecessor_index()recomputed the same information (the number of indices of the predecessor node traversed by taking a stride along an axis) for eachupdate. Since this node is already extremely lightweight (it's buffer is simply it's predecessors buffer), we can easily cache this data.