Skip to content

feat(viewer): render github title source links#19

Merged
dutifulbob merged 1 commit into
mainfrom
feat/github-title-source-links
May 14, 2026
Merged

feat(viewer): render github title source links#19
dutifulbob merged 1 commit into
mainfrom
feat/github-title-source-links

Conversation

@dutifulbob

Copy link
Copy Markdown
Member

Summary

  • add a source URL classifier for title source links
  • render GitHub source links with the checked-in GitHub logo
  • show #number for GitHub issue and PR URLs
  • keep Discord and generic external link behavior intact

Validation

  • pnpm test -- StoryDetailPanel.test.tsx sourceLinks.test.ts
  • pnpm typecheck
  • pnpm build

@dutifulbob

Copy link
Copy Markdown
Member Author

Final report:

Implemented GitHub title source link rendering through the shared title source-link boundary.

Validation passed:

  • pnpm test -- StoryDetailPanel.test.tsx sourceLinks.test.ts
  • pnpm typecheck
  • pnpm build
  • codex review --base main: no actionable issues
  • CI: Backend (Go) passed, Frontend (TypeScript) passed

Behavior:

  • Discord title links keep the existing Discord message treatment.
  • GitHub issue and PR URLs render with the GitHub logo plus #number.
  • Generic GitHub URLs render as logo-only title actions.
  • Generic external URLs keep the external-link icon.

@dutifulbob dutifulbob merged commit da4bb95 into main May 14, 2026
2 checks passed
@dutifulbob dutifulbob deleted the feat/github-title-source-links branch May 14, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant