Replace jest with vitest, ts-node with tsx, upgrade eslint 10#96
Merged
bh2smith merged 2 commits intoMay 5, 2026
Conversation
- Remove jest, ts-jest, @types/jest, ts-node - Add vitest (with globals mode) and tsx - Upgrade eslint 9 → 10 - Override flatted to >=3.4.2 to fix remaining eslint transitive vuln - Migrate jest.mock/jest.fn to vi.mock/vi.fn in deprecation test - pnpm audit now reports 0 vulnerabilities
belen-pruvost
approved these changes
May 5, 2026
Vitest deprecated the done() callback pattern. Convert all beforeEach(done => setTimeout(done, 1000)) to async promise-based waits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jest.mock/jest.fnusage tovi.mock/vi.fn.difftransitive dependency.pnpm.overridesforflatted>=3.4.2since eslint 10 still ships a stale transitive version.pnpm auditnow reports 0 vulnerabilities (down from 22 open Dependabot alerts at the start of PLA-2016)Net result: -2,089 lines of lockfile, 0 audit findings.
Test plan
pnpm run buildpassespnpm run lintpasses (eslint 10, no config changes needed)pnpm auditreturns cleanResolves https://linear.app/dune/issue/PLA-2049