Allow incremental together with clustered#33
Open
Dtenwolde wants to merge 6 commits into
Open
Conversation
Merged
Member
Author
|
I suppose running CI in reduced mode is fine? |
lnkuiper
reviewed
Jul 2, 2026
| "%%fts_schema%%.terms;\n" | ||
| "DROP TABLE %%fts_schema%%.terms;\n" | ||
| "CREATE VIEW %%fts_schema%%.terms AS SELECT termid, docid, fieldid FROM " | ||
| "%%fts_schema%%.%s ORDER BY termid, fieldid, docid;", |
Member
There was a problem hiding this comment.
Won't this ORDER BY here make performance worse? The incrementally appended data (after the initial index creation) is not physically clustered, which I am OK with, but I don't think forcing an ORDER BY will improve performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32, where we temporarily disallowed using
incremental=trueandcluster_terms=truetogether.This PR allows both options to be used together.
Compared to #32 clustered incremental maintenance has some extra cost because we preserve ordered
termsaccess across inserts and deletes, but the overhead stays modest.Benchmark summary:
Overall, clustered + incremental index maintenance performs similarly for inserts and mixed workloads, with some delete overhead, but all measured scenarios stayed below 2x slowdown.