[develop]: Add regression testing#28
Draft
georgemccabe wants to merge 69 commits into
Draft
Conversation
…ent branch and latest commit
…is currently written to be run from that directory
…anch directory before running tests
…und by end-to-end test runs
…ed up test runs. Clean up logic to report if a test dir is not found in either baseline or new output
- Replace call to load_modules_wflow.sh with call to setup_conda.sh - Since we no longer have module loads, ROCOTO_PATH is provided as a variable in the machine file for each platform
… does this automatically
Read ROCOTO_PATH from the machine config file and prefix all calls to rocotorun and rocotostat with it, consistent with launch_vx_wflow.sh. Machines without ROCOTO_PATH (jet, noaacloud, linux, macos) fall back to bare binary names. rocoto_path is stored in the WE2E monitor YAML and propagated through update_expt_status/compare_rocotostat; added to all non-task entry skip lists to avoid being treated as a task. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The statuses loop in update_expt_status had 8-space indentation while the other two skip lists had 12-space indentation, so the replace_all edit missed it. This caused a TypeError when iterating over the expt dict since rocoto_path (a string) was not excluded from the task loop. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolve SCRIPT_DIR from ${BASH_SOURCE[0]} at the top and anchor all
relative file/directory references (conda_loc, conda/, environment.yml)
to it. Also replaces readlink -f with cd && pwd for macOS compatibility
without requiring GNU coreutils.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…! Also, make HAFS-A WE2E test case work on all platforms
…observations rather than model data
…p_conda.sh script
…ut files that were skipped or had no differences
…ng the rocoto exes
…write permissions set so multiple users can run tests in that area
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Note: This PR contains changes from PR #25 to address some issues running the tests. Until that PR is merged, the differences in this PR only can be viewed from this link:
feature/fix_some_issues...feature/regression_tests
vx_diffwhich creates/activates the diff environment instead of thevx_workflowenvironmentAn example of the log file created by the diff script can be found on ursa:
/scratch3/BMC/dtc/George.Mccabe/dtc-vx-workflow_testing/diff_WE2E_20260630200405.txt
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):