Feature #3321 add rps#3322
Open
JohnHalleyGotway wants to merge 3 commits into
Open
Conversation
…te it in at least one METplus use case.
11 tasks
Coverage Report for CI Build 28463714518Coverage decreased (-0.01%) to 92.054%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
This PR modifies an existing use case to trigger Ensemble-Stat to write an RPS output line.
Describe testing already performed for these changes:
Tested manually on seneca to confirm it produces non-trivial output.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the proposed config use case change and resulting RPS output line.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
None needed.
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Adds 1 new line of output to an existing .stat file.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Tues, July 7].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases