Skip to content

Feature #3321 add rps#3322

Open
JohnHalleyGotway wants to merge 3 commits into
developfrom
feature_3321_add_RPS
Open

Feature #3321 add rps#3322
JohnHalleyGotway wants to merge 3 commits into
developfrom
feature_3321_add_RPS

Conversation

@JohnHalleyGotway

@JohnHalleyGotway JohnHalleyGotway commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Testing

This PR modifies an existing use case to trigger Ensemble-Stat to write an RPS output line.

  • Describe testing already performed for these changes:

    Tested manually on seneca to confirm it produces non-trivial output.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the proposed config use case change and resulting RPS output line.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    None needed.

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    Adds 1 new line of output to an existing .stat file.

V13.0.0 WOFS  NA   000000    20200615_180000 20200615_180000 000000   20200615_180000 20200615_180000 APCP_01  kg/m^2     A1       GaugeCorrQPE01H_01 mm        A1      MRMS_QPE FULL    NEAREST     1           >0,>1,>2,>3,>4,>5 NA         NA         NA    RPS       90000  18        0.018252     0.038814      0.089752    0.06919   NA          0.2291     0.93081
  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Tues, July 7].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the METplus-13.0.0 milestone Jun 25, 2026
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Jun 25, 2026
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development Jun 25, 2026
@JohnHalleyGotway JohnHalleyGotway linked an issue Jun 25, 2026 that may be closed by this pull request
11 tasks
@coveralls

coveralls commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28463714518

Coverage decreased (-0.01%) to 92.054%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 10471
Covered Lines: 9639
Line Coverage: 92.05%
Coverage Strength: 0.92 hits per line

💛 - Coveralls

@JohnHalleyGotway JohnHalleyGotway requested a review from CPKalb June 30, 2026 22:43
@JohnHalleyGotway JohnHalleyGotway marked this pull request as ready for review June 30, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Update Truth: For dtcenter/MET#3398

2 participants