Skip to content

feat: Add getSize and getSizeWithHeaders support#361

Open
AKASHDHARDUBEY wants to merge 1 commit into
dream-horizon-org:mainfrom
AKASHDHARDUBEY:feat/get-size-support
Open

feat: Add getSize and getSizeWithHeaders support#361
AKASHDHARDUBEY wants to merge 1 commit into
dream-horizon-org:mainfrom
AKASHDHARDUBEY:feat/get-size-support

Conversation

@AKASHDHARDUBEY

Copy link
Copy Markdown

Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

Summary:

Explain the motivation for making this change. What existing problem does the pull request solve?

Example: This PR improves cache handling for FastImage by implementing proper invalidation when source URLs change with the same cache key. This solves the issue where stale images would continue to display after content updates.

Changelog:

Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

Example:

  • [ANDROID] [FIXED] - Fixed memory leak when rapidly changing FastImage sources

Test Plan:

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.

Example:

  • Tested image loading with PNG, JPEG, GIF formats
  • Verified cache behavior with FastImage.preload()
  • Tested on iOS 14 and Android 10
  • Command: cd example && yarn ios/android

@orca-security-in orca-security-in Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@github-actions

github-actions Bot commented Dec 9, 2025

Copy link
Copy Markdown

🚀 Thanks for your first Pull Request!
Your contribution is greatly appreciated, and a maintainer will review it soon.
Meanwhile, feel free to check out other issues or share your thoughts on the project.
We’re excited to have you on board! 🎉

@devanshsaini11

devanshsaini11 commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

@AKASHDHARDUBEY Thanks for raising this PR, can you kindly update PR description

Edit: Lint checks are failing can you fix them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants