Add short format option#2
Open
Madh93 wants to merge 1 commit intodpzaba:masterfrom
Open
Conversation
Owner
|
Hi @Madh93 I did not realize of this PR I did not get any notification, sorry for the delay. Give me some time to think about it, thanks. |
dpzaba
reviewed
Aug 1, 2018
|
|
||
| if rest.nonzero? && !(unit_time == :seconds && opts[:skip_seconds]) | ||
| word = I18n.t(unit_time.to_s, count: rest, scope: locale_prefix) | ||
| word = (opts[:short_format] ? word[0] : word) |
Owner
There was a problem hiding this comment.
what do you think about instead of do word[0], to have a short_format in our locales somehow? No idea if word[0] works for all locales
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a short format option.