Skip to content

Conversation

@dotnet-docker-bot
Copy link
Contributor

Updates the common Docker engineering infrastructure with latest changes from the dotnet/docker-tools repo.

lbussell added a commit to dotnet/docker-tools that referenced this pull request Jan 28, 2026
## Summary
Fix Windows PR validation failing because ImageBuilder is not pulled.
The breaking behavior was added in
#1947.

Job-specific init steps (customBuildInitSteps,
customGenerateMatrixInitSteps, etc.) were being merged into
customInitSteps before being passed to init-common.yml. This caused
init-imagebuilder.yml to skip the default ImageBuilder pull when any
job-specific steps were provided, since it checks if customInitSteps is
non-empty.

## Changes
- Add separate parameters for job-specific init steps in job templates:
  - `customBuildInitSteps` in build-images.yml
  - `customCopyBaseImagesInitSteps` in copy-base-images.yml
  - `customGenerateMatrixInitSteps` in generate-matrix.yml
- Update build-and-test.yml to pass these parameters separately instead
of merging them
- Add clarifying comments to distinguish the two types of init steps

## Testing
Testing via dotnet/dotnet-docker#7016
@dotnet-docker-bot dotnet-docker-bot force-pushed the dotnet-docker-nightly-update-docker-tools branch from 8e361cd to 8f8abba Compare January 28, 2026 21:09
@lbussell lbussell merged commit f756a16 into dotnet:nightly Jan 28, 2026
123 checks passed
@github-actions github-actions bot added the needs-backport PR that should be backported to another branch label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport PR that should be backported to another branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants