-
Notifications
You must be signed in to change notification settings - Fork 321
Create separate flaky tests pipeline #3936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added new flaky test pipeline and plumbed it through the MDS core pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Splits flaky test execution into a dedicated Azure DevOps pipeline and introduces a flakyTestsOnly switch to run either flaky-only or non-flaky-only test suites via the shared CI templates.
Changes:
- Added a new
CI-SqlClient-Flakypipeline YAML that runs only flaky tests onmain(CI + weekday schedule). - Plumbed a new
flakyTestsOnlyboolean parameter throughdotnet-sqlclient-ci-core.yml→ci-run-tests-stage.yml→ci-run-tests-job.yml→run-all-tests-step.yml. - Refactored the test-running step template to conditionally run flaky vs non-flaky test targets (and mark flaky runs
continueOnError).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/sqlclient/sqlclient-flaky-tests-pipeline.yml | New pipeline definition that extends the core template with flakyTestsOnly: true. |
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Adds flakyTestsOnly parameter and forwards it into the test stage template. |
| eng/pipelines/common/templates/steps/run-all-tests-step.yml | Adds conditional branching to run flaky-only vs non-flaky-only test tasks. |
| eng/pipelines/common/templates/stages/ci-run-tests-stage.yml | Accepts/forwards flakyTestsOnly into test jobs. |
| eng/pipelines/common/templates/jobs/ci-run-tests-job.yml | Accepts/forwards flakyTestsOnly into the test execution step template. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3936 +/- ##
===========================================
- Coverage 90.82% 67.55% -23.28%
===========================================
Files 6 263 +257
Lines 316 66198 +65882
===========================================
+ Hits 287 44718 +44431
- Misses 29 21480 +21451
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The flaky tests are preventing PR and CI pipeline runs from completing successfully. They don't add any confidence to those pipelines, so we will split them out into their own pipeline. This has many benefits:
Testing
NOTE: We won't be able to test the new Flaky Tests pipeline until this merges to main. The new YAML file must exist on main before Azure DevOps will allow us to create the new pipeline in the Public project.