Skip to content

Fix MDS Official Pipeline#3933

Merged
mdaigle merged 6 commits intomainfrom
dev/paul/fix-mds-official-pipeline
Feb 5, 2026
Merged

Fix MDS Official Pipeline#3933
mdaigle merged 6 commits intomainfrom
dev/paul/fix-mds-official-pipeline

Conversation

@paulmedynski
Copy link
Contributor

Description

The recent Azure Split PRs have broken the MDS Official pipelines in our ADO.Net project. This PR fixes a few errors and makes some select tweaks to simplify that pipeline a bit.

Testing

The Official pipeline has already been run against these changes and is working. There should be no effect to other pipelines, but normal PR/CI runs will confirm.

@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Feb 3, 2026
@paulmedynski paulmedynski requested a review from a team as a code owner February 3, 2026 22:52
Copilot AI review requested due to automatic review settings February 3, 2026 22:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes broken MDS Official pipeline issues introduced by recent Azure Split changes. The main focus is simplifying variable management and correcting property names in the build configuration.

Changes:

  • Consolidated pipeline variable definitions by removing mds-variables.yml and moving "Release Variables" group directly into consuming files
  • Simplified MDS package version variables to use direct values instead of computed expressions with Major/Minor/Patch/Preview/Revision components
  • Fixed build property name from MdsAssemblyFileVersion to AssemblyFileVersion to match the actual property used in the build system
  • Renamed packageFolderName variable to mdsArtifactName for clarity
  • Hardcoded build configuration to Release for official builds instead of using a variable
  • Removed unused ASSEMBLY_VERSION variable extraction step
  • Added .NET SDK installation step to build job for consistency
  • Cleaned up trailing whitespace throughout multiple pipeline files

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
eng/pipelines/libraries/mds-variables.yml Deleted file - its single variable group declaration moved to consuming files
eng/pipelines/libraries/mds-validation-variables.yml Added Release Variables group, removed reference to deleted mds-variables.yml, cleaned trailing whitespace
eng/pipelines/libraries/common-variables.yml Simplified version variable definitions from computed expressions to direct values, improved comments, cleaned trailing whitespace
eng/pipelines/libraries/build-variables.yml Added Release Variables group, removed reference to deleted mds-variables.yml
eng/pipelines/dotnet-sqlclient-signing-pipeline.yml Renamed packageFolderName to mdsArtifactName, cleaned trailing whitespace
eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml Fixed property name from MdsAssemblyFileVersion to AssemblyFileVersion
eng/pipelines/common/templates/jobs/validate-signed-package-job.yml Removed unused ASSEMBLY_VERSION variable extraction, cleaned trailing whitespace
eng/pipelines/common/templates/jobs/build-signed-package-job.yml Added .NET SDK installation step, hardcoded configuration to Release, cleaned trailing whitespace

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.47%. Comparing base (a0357b2) to head (40ab059).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a0357b2) and HEAD (40ab059). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (a0357b2) HEAD (40ab059)
addons 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3933      +/-   ##
==========================================
- Coverage   74.89%   67.47%   -7.43%     
==========================================
  Files         269      263       -6     
  Lines       43274    66290   +23016     
==========================================
+ Hits        32410    44728   +12318     
- Misses      10864    21562   +10698     
Flag Coverage Δ
addons ?
netcore 67.55% <ø> (-7.37%) ⬇️
netfx 66.52% <ø> (-7.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle merged commit bfd6170 into main Feb 5, 2026
293 checks passed
@mdaigle mdaigle deleted the dev/paul/fix-mds-official-pipeline branch February 5, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants