Closed
Conversation
- Testing suppression of errors/warnings in the UI due to flaky tests.
- Testing suppression of errors/warnings in the UI due to flaky tests.
- Added targets for flaky tests that ignore failures entirely.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the Azure DevOps pipeline configuration to suppress spurious errors and warnings from flaky tests in the pipeline UI. The changes implement two distinct strategies depending on the pipeline context:
Changes:
- Created new dedicated MSBuild targets (
RunFlakyUnitTests,RunFlakyFunctionalTests,RunFlakyManualTests) in build.proj that useIgnoreExitCodeandIgnoreStandardErrorWarningFormatto suppress error output - Updated the PR/CI pipeline template (run-all-tests-step.yml) to use the new flaky test targets and removed explicit filter parameters
- Removed flaky test execution entirely from the MDS Official pipeline templates (netfx and netcore), and updated regular tests to exclude flaky tests
- Added whitespace cleanup across multiple pipeline files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/common/templates/steps/run-all-tests-step.yml | Updated flaky unit test tasks to use new RunFlakyUnitTests target; removed explicit filter parameters; cleaned up trailing whitespace |
| eng/pipelines/common/templates/steps/build-and-run-tests-netfx-step.yml | Removed separate flaky test tasks; added filters to regular tests to exclude flaky tests; added pipeline identifier comment |
| eng/pipelines/common/templates/steps/build-and-run-tests-netcore-step.yml | Removed separate flaky test tasks; added filters to regular tests to exclude flaky tests; added pipeline identifier comment |
| eng/pipelines/common/templates/jobs/run-tests-package-reference-job.yml | Whitespace cleanup and added pipeline identifier comment |
| build.proj | Added new MSBuild targets for running flaky tests with error suppression; updated comments to clarify non-flaky test targets |
Comments suppressed due to low confidence (1)
eng/pipelines/common/templates/steps/run-all-tests-step.yml:145
- The flaky functional tests task is still using the old target name
-t:RunFunctionalTestswith a filter instead of the new dedicated target-t:RunFlakyFunctionalTests. This is inconsistent with the changes in the Linux/macOS section (line 242) and the build.proj file, where new dedicated targets for flaky tests were created. The target should be changed to-t:RunFlakyFunctionalTestsand the-p:Filter="category=flaky"line should be removed to match the pattern used for unit tests in this same file.
-t:RunFunctionalTests
-p:TF=${{ parameters.targetFramework }}
-p:TestSet=${{ parameters.testSet }}
-p:ReferenceType=${{ parameters.referenceType }}
-p:MdsPackageVersion=${{ parameters.mdsPackageVersion }}
-p:Filter="category=flaky"
paulmedynski
commented
Feb 3, 2026
| --blame-hang-dump-type full | ||
| --blame-hang-timeout 10m | ||
|
|
||
| - task: DotNetCoreCLI@2 |
Contributor
Author
There was a problem hiding this comment.
Official builds don't need to be running flaky tests. We currently don't run any tests in the official MDS builds anyway (an issue we should probably fix).
apoorvdeshmukh
approved these changes
Feb 4, 2026
Contributor
Author
|
Abandoning this effort. I think we want to take a different approach to flaky tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds distinct flaky test targets to
build.projthat run the flaky tests and ignore all errors entirely. This suppresses spurious errors/warnings from the flaky tests in the Azure DevOps UI for pipeline runs, and avoids the orange (!) and yellow status throughout the various pipelines. We know the flaky tests will fail - we don't need to see it on every pipeline run. Seeing all of their errors risks hiding/masking other legitimate problems that should be noticed.Testing
Normal PR/CI runs will confirm.