Disable repatching a dirty root volume - #1179
Merged
Merged
Conversation
crystall1nedev
changed the title
First, we check for the existence of OpenCore-Legacy-Patcher.plist. If the file does not exist, checking for "Broken" in the diskutil output for the "Sealed" key on the root volume will help continue - if it's broken, unpatching is required to continue. If the file does exist, checking for "Commit URL" will help determine if the current copy of OCLP was used to install any patches. Should the patches be from a different commit, unpatching is required to continue. With the commit matching, we then check for any non-wireless patches that are currently installed on the system. This allows for users to continue patching wireless first and everything else later, while also ensuring that repatching is blocked when all patches are installed.
This is already handled elsewhere.
Collaborator
Author
|
All of these changes have been tested with local builds of OpenCore Legacy Patcher (these commits cherry-picked onto the I have verified that the functionality is present and works in these scenarios:
|
crystall1nedev
force-pushed
the
repatching-block
branch
from
December 16, 2025 01:09
6f95ce2 to
e158eb9
Compare
crystall1nedev
marked this pull request as ready for review
December 16, 2025 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the complexity and variability of the patches included in OpenCore Legacy Patcher, we cannot "trust" that an already-patched install will not break with updated patches.
A good example of this is in the
wirelessbranch (#1177). The new wireless patchset will break existing Sequoia installations if the user decides to repatch the system volume without first restoring it to a sealed state.This PR implements a block on repatching over an existing installation when:
This should allow users to repatch over an existing install in only one scenario: to enable wireless functionality in order to download the KDK or MetallibSupportPkg.