Version 2.3.2 -> Version 2.4.0 (Proposed): Update React & React-Dom to 17.0.1.#71
Closed
DoctorDerek wants to merge 1 commit into
Closed
Version 2.3.2 -> Version 2.4.0 (Proposed): Update React & React-Dom to 17.0.1.#71DoctorDerek wants to merge 1 commit into
DoctorDerek wants to merge 1 commit into
Conversation
|
It would be great if one of the maintainers could merge this, I hate having to use --force or --ignore. Thanks. |
|
Can we get this merged? @donavon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes issue #70. This PR is an alternative to PR #68 and would update the semver of use-dark-mode from 2.3.2 to 2.4.0 to reflect the new peer dependency (React ^16.8 -> React ^17.0.1).
No code needs to be changed, as existing use-dark-mode v2.3.1 works fine with React 17; see: https://codesandbox.io/s/usedarkmode-demo-forked-fo70t?file=/src/App.js (But I took out the import React from "react" statement! ha!)